Feedback-ID: ie3de48e3:Fastmail
Date: Fri, 28 Nov 2025 19:00:29 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
Message-ID: <202511281759.7zxt6cjzikzx@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <E1vOJwR-001XFf-0r@gemulon.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202511281759.7zxt6cjzikzx%40alvherre.pgsql>
Precedence: bulk

On 2025-Nov-26, Jeff Davis wrote:

> Inline pg_ascii_tolower() and pg_ascii_toupper().

I think this broke the CI on (some flavors of?) Windows.  In
https://cirrus-ci.com/task/6080935063453696
I got

[19:09:39.518] [1597/2357] Linking target src/backend/postgres.exe
[19:09:39.518] FAILED: [code=1] src/backend/postgres.exe 
[19:09:39.518] "cc" @src/backend/postgres.exe.rsp
[19:09:39.518] C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: src/backend/postgres_lib.a.p/commands_event_trigger.c.obj: in function `filter_list_to_array':
[19:09:39.518] c:\cirrus\build/../src/backend/commands/event_trigger.c:377:(.text+0x2a5): undefined reference to `pg_ascii_toupper'
[19:09:39.518] collect2.exe: error: ld returned 1 exit status
[19:09:39.520] [1598/2357] Compiling C object src/backend/snowball/dict_snowball.dll.p/libstemmer_stem_ISO_8859_1_indonesian.c.obj
[19:09:39.521] [1599/2357] Compiling C object src/backend/snowball/dict_snowball.dll.p/libstemmer_stem_ISO_8859_1_irish.c.obj
[19:09:39.616] [1600/2357] Compiling C object src/backend/snowball/dict_snowball.dll.p/libstemmer_stem_ISO_8859_1_english.c.obj
[19:09:39.648] [1601/2357] Compiling C object src/backend/replication/pgoutput/pgoutput.dll.p/pgoutput.c.obj
[19:09:39.760] [1602/2357] Compiling C object src/backend/snowball/dict_snowball.dll.p/libstemmer_stem_ISO_8859_1_german.c.obj
[19:09:39.762] ninja: build stopped: subcommand failed.


I'm surprised it didn't do anything to the buildfarm.  Are we lacking coverage?

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/