Feedback-ID: ie3de48e3:Fastmail
Date: Wed, 25 Feb 2026 11:27:48 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jelte Fennema-Nio <postgres@jeltef.nl>,
	pgsql-hackers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>,
	Nathan Bossart <nathandbossart@gmail.com>
Subject: Re: pgsql: libpq: Grease the protocol by default
Message-ID: <202602251006.wfzc3mwwt56l@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAOYmi+=UbmYgAFCgLzMqqniGXr4+GVGvz+C-petTF=+dEnHvkQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202602251006.wfzc3mwwt56l%40alvherre.pgsql>
Precedence: bulk

On 2026-Feb-24, Jacob Champion wrote:

> On Tue, Feb 24, 2026 at 12:40 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > These look sane to me.  I might suggest a small wording change in
> > the <= 17 patches:
> >
> > -        * Back-branch-specific complication: for libpq versions prior to PG18,
> > +        * Back-branch-specific complication: in libpq versions prior to PG18,
> >
> > but it probably isn't worth the trouble to edit four separate patches.
> 
> By the power of sed, it is done.

What I normally do for this kind of thing is commit the typo fix in a
separate commit, then cherry-pick that to other branches, then use
rebase -i to squash it as a fix-up of the previous commit on all
branches.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Y una voz del caos me habló y me dijo
"Sonríe y sé feliz, podría ser peor".
Y sonreí. Y fui feliz.
Y fue peor.