Feedback-ID: ie3de48e3:Fastmail
Date: Mon, 16 Mar 2026 16:48:04 +0100
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix small memory leak in get_dbname_oid_list_from_mfile().
Message-ID: <202603161539.zldv3z456gn4@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKYtNAosdz3upg7AnrK5m7D107+BdXp2qDVDYFK_8w0DZvP5qg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202603161539.zldv3z456gn4%40alvherre.pgsql>
Precedence: bulk

On 2026-Mar-16, Mahendra Singh Thalor wrote:

> We were trimming slashes due to the below test case.
> 
> *Ex:*
>  ./pg_dumpall -f dumpdir --format=d
> 
> ./pg_restore *dumpdir/ *-d postgres -C --format=d --verbose
> pg_restore: found database "template1" (OID: 1) in file "*dumpdir//map.dat*"
> pg_restore: found database "postgres" (OID: 5) in file "*dumpdir//map.dat*"
> pg_restore: found 2 database names in "map.dat"
> pg_restore: need to restore 2 databases out of 2 databases
> 
> Here, before map.dat, there were 2 slashes so we were trimming slashes.
> Please add your opinion for this output.

I think this is perfectly fine.  Two slashes work correctly, and many
other tools behave this way when given redundant slashes.  If the user
doesn't want to see the redundant slashes, they can just not specify a
trailing slash in the argument value.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)