Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIY3E-0001Bb-Ov for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Feb 2022 15:41:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nIY3D-0001Ee-GB for pgsql-hackers@arkaria.postgresql.org; Fri, 11 Feb 2022 15:41:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIY3D-0001EV-77 for pgsql-hackers@lists.postgresql.org; Fri, 11 Feb 2022 15:41:35 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIY3A-0008Ce-7A for pgsql-hackers@lists.postgresql.org; Fri, 11 Feb 2022 15:41:34 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21BFfR1N2027231; Fri, 11 Feb 2022 10:41:27 -0500 From: Tom Lane To: Justin Pryzby cc: Christoph Berg , Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc In-reply-to: <20220211153549.GE31460@telsasoft.com> References: <2023925.1644591595@sss.pgh.pa.us> <20220211153549.GE31460@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Fri, 11 Feb 2022 09:35:49 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2027229.1644594087.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Feb 2022 10:41:27 -0500 Message-ID: <2027230.1644594087@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Fri, Feb 11, 2022 at 09:59:55AM -0500, Tom Lane wrote: >> This seems like a pretty bad idea even if it weren't failing outright. >> We should be examining the version of the file that's in the source >> tree; the one in the installation tree might have version-skew >> problems, if you've not yet done "make install". > My original way used the source tree, but Michael thought it would be an= issue > for "installcheck" where the config may not be available. Yeah, you are at risk either way, but in practice nobody is going to be running these TAP tests without a source tree. > This is what I had written: > FROM (SELECT regexp_split_to_table(pg_read_file('postgresql.conf'), '\n'= ) AS ln) conf That's not using the source tree either, but the copy in the cluster-under-test. I'd fear it to be unstable in the buildfarm, where animals can append whatever they please to the config file being used by tests. regards, tom lane