Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 65AE963248A for ; Thu, 22 Jan 2009 19:27:54 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 83883-09 for ; Thu, 22 Jan 2009 19:27:50 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id E6B6063242D for ; Thu, 22 Jan 2009 19:27:50 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n0MNRlUp020644; Thu, 22 Jan 2009 18:27:47 -0500 (EST) To: Magnus Hagander cc: pgsql-hackers@postgreSQL.org Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. In-reply-to: <20090122100948.89F977559ED@cvs.postgresql.org> References: <20090122100948.89F977559ED@cvs.postgresql.org> Comments: In-reply-to mha@postgresql.org (Magnus Hagander) message dated "Thu, 22 Jan 2009 10:09:48 +0000" Date: Thu, 22 Jan 2009 18:27:47 -0500 Message-ID: <20643.1232666867@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200901/1667 X-Sequence-Number: 132311 mha@postgresql.org (Magnus Hagander) writes: > Explicitly bind gettext to the correct encoding on Windows. I have a couple of objections to this patch. First, what happens if it fails to find a matching table entry? (The existing answer is "nothing", but that doesn't seem right.) Second and more critical, it adds still another data structure that has to be maintained when the list of encodings changes, and it doesn't even live in the same file as any existing encoding-information table. What makes more sense to me is to add a table to encnames.c that provides the gettext name of every encoding that we support. regards, tom lane