From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Convert some extern variables to static
In-reply-to: <E1sOW2T-003tAa-EP@gemulon.postgresql.org>
References: <E1sOW2T-003tAa-EP@gemulon.postgresql.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Tue, 02 Jul 2024 05:26:50 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2078837.1726787728.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 19 Sep 2024 19:15:28 -0400
Message-ID: <2078838.1726787728@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2078838.1726787728%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> Convert some extern variables to static

I'm surprised it took me so long to notice, but this commit
makes headerscheck unhappy:

$ src/tools/pginclude/headerscheck =

In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/EAN13.h:26:20: warning: 'EAN13_range' defined but not used [=
-Wunused-variable]
 static const char *EAN13_range[][2] =3D {
                    ^~~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISBN.h:983:20: warning: 'ISBN_range_new' defined but not use=
d [-Wunused-variable]
 static const char *ISBN_range_new[][2] =3D {
                    ^~~~~~~~~~~~~~
./contrib/isn/ISBN.h:50:20: warning: 'ISBN_range' defined but not used [-W=
unused-variable]
 static const char *ISBN_range[][2] =3D {
                    ^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISMN.h:45:20: warning: 'ISMN_range' defined but not used [-W=
unused-variable]
 static const char *ISMN_range[][2] =3D {
                    ^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISSN.h:46:20: warning: 'ISSN_range' defined but not used [-W=
unused-variable]
 static const char *ISSN_range[][2] =3D {
                    ^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/UPC.h:26:20: warning: 'UPC_range' defined but not used [-Wun=
used-variable]
 static const char *UPC_range[][2] =3D {
                    ^~~~~~~~~

We could either revert the static-ification of these variables,
or move them into isn.c which seems to be the sole consumer.

			regards, tom lane