Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5sXs-0004nu-8s for pgsql-committers@arkaria.postgresql.org; Thu, 05 Sep 2019 14:15:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1i5sXq-0006tV-U7 for pgsql-committers@arkaria.postgresql.org; Thu, 05 Sep 2019 14:15:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5sXq-0006SZ-KY for pgsql-committers@lists.postgresql.org; Thu, 05 Sep 2019 14:15:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1i5sXn-0001LY-RS for pgsql-committers@lists.postgresql.org; Thu, 05 Sep 2019 14:15:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x85EFOgM020797; Thu, 5 Sep 2019 10:15:24 -0400 From: Tom Lane To: Peter Eisentraut cc: Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix compiler warning In-reply-to: <5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com> References: <20190902010409.GC1841@paquier.xyz> <20190902080326.GB25912@paquier.xyz> <5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com> Comments: In-reply-to Peter Eisentraut message dated "Thu, 05 Sep 2019 16:05:40 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20795.1567692924.1@sss.pgh.pa.us> Date: Thu, 05 Sep 2019 10:15:24 -0400 Message-ID: <20796.1567692924@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut writes: > The tree currently does not compile without warnings on Windows (for > me), so it doesn't seem worth fixing warnings piece by piece in the > backbranches. Hm, I see no warnings on e.g. dory. What are you seeing, and with what toolchain? (Or should I be asking about build options?) regards, tom lane