Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oa1Py-0006EA-9p for pgsql-committers@arkaria.postgresql.org; Sun, 18 Sep 2022 21:01:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oa1Px-0006hj-4I for pgsql-committers@arkaria.postgresql.org; Sun, 18 Sep 2022 21:01:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oa1Pw-0006ha-SO for pgsql-committers@lists.postgresql.org; Sun, 18 Sep 2022 21:01:32 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oa1Pu-0004vp-Hl for pgsql-committers@lists.postgresql.org; Sun, 18 Sep 2022 21:01:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28IL1Skh208623; Sun, 18 Sep 2022 17:01:29 -0400 From: Tom Lane To: Peter Geoghegan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Harmonize reorderbuffer parameter names. In-reply-to: References: <92291.1663476459@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Sun, 18 Sep 2022 11:18:56 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <208621.1663534888.1@sss.pgh.pa.us> Date: Sun, 18 Sep 2022 17:01:28 -0400 Message-ID: <208622.1663534888@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > I see what happened here: while the > "readability-inconsistent-declaration-parameter-name" check works > equally well with extern functions and functions with local linkage, > the same cannot be said for the "readability-named-parameter" check. > The latter only seems to work with functions that have local linkage. That's kind of annoying --- seems to put a serious crimp in any plans to check this mechanically. regards, tom lane