Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1buOhf-0001P1-5c for pgsql-committers@arkaria.postgresql.org; Wed, 12 Oct 2016 18:56:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1buOhe-0003lN-Or for pgsql-committers@arkaria.postgresql.org; Wed, 12 Oct 2016 18:56:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1buOhd-0003dE-Bv for pgsql-committers@postgresql.org; Wed, 12 Oct 2016 18:56:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1buOha-0005uV-Um for pgsql-committers@postgresql.org; Wed, 12 Oct 2016 18:56:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u9CIuTe1020953; Wed, 12 Oct 2016 14:56:29 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve In-reply-to: References: Comments: In-reply-to Peter Eisentraut message dated "Wed, 12 Oct 2016 14:17:22 -0400" Date: Wed, 12 Oct 2016 14:56:29 -0400 Message-ID: <20952.1476298589@sss.pgh.pa.us> X-Pg-Spam-Score: -2.2 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Peter Eisentraut writes: > On 10/12/16 12:20 PM, Tom Lane wrote: >> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers. > It looks like this or a related commit has caused these compiler warnings: > pg_dump.c: In function 'getTypes': > pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used > [-Werror=unused-but-set-variable] > int i_typoutput; > ^~~~~~~~~~~ > pg_dump.c:3691:8: error: variable 'i_typinput' set but not used > [-Werror=unused-but-set-variable] > int i_typinput; > ^~~~~~~~~~ Ah, I'd not noticed because my compiler doesn't complain. Will fix, thanks. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers