Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs8QA-006uCU-GH for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 21:13:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qs8Q7-00CopG-1X for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 21:13:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs8Q6-00Cop8-Qg for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 21:13:07 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qs8Q1-000qd6-Oy for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 21:13:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39FLCwXx2124061; Sun, 15 Oct 2023 17:12:58 -0400 From: Tom Lane To: Peter Geoghegan cc: Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic In-reply-to: References: <1974777.1697327121@sss.pgh.pa.us> <20231015000358.2d@rfd.leadboat.com> <1980111.1697329678@sss.pgh.pa.us> <20231015013607.61@rfd.leadboat.com> <1991711.1697335375@sss.pgh.pa.us> Comments: In-reply-to Peter Geoghegan message dated "Sun, 15 Oct 2023 10:51:00 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <2124059.1697404378.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 15 Oct 2023 17:12:58 -0400 Message-ID: <2124060.1697404378@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > On Sat, Oct 14, 2023 at 7:02=E2=80=AFPM Tom Lane wro= te: >> Noah Misch writes: >>> That's right. We don't have a standard that installcheck of v13.N wil= l have >>> zero diffs on an initdb from v13.0. >> Um ... don't we? I do not recall very many cases where we changed >> initial catalog contents at all in a point release, and I don't think >> any of those cases intentionally created regression diffs. > This did come up in review. I deferred to Noah on the question. FWIW > if I had authored this bugfix, it wouldn't have touched catalog > contents on the backbranches. To research this, I looked at every post-dot-zero commit that touched src/include/catalog, going back to the 7.4 branch (~ 2003). While there are a lot that adjust internal C function declarations or the like, there are darn few that touch the catalog data. Ignoring a few that just adjusted pg_description entries, I found 283262cd9 et al Fix bogus provolatile/proparallel markings on a few built-in functions aa7e04cb5 et al Clean up some lack-of-STRICT issues in the core code, too 6e0a053a9 Correct volatility markings of a few json functions cb651b624 et al Fix incorrect pg_proc.proallargtypes entries for two built-in function= s 0b11a1525 et al Mark to_number() and the numeric-type variants of to_char() as stable,= not aed597102 anyarray really needs to be declared with typalign =3D 'd', so that en= tries in pg_statistic are correctly aligned if they contain values that requ= ire double alignment. Too bad we cannot force initdb for this in 7.4 bran= ch. None of these commits had any side-effects on regression test cases, and the log entry for cb651b624 explicitly notes that we didn't add the same regression test case as in HEAD for fear that it'd fail with older catalog contents. So I beg to differ with Noah: I think we *do* have a policy against doing this. At least, we've not actually done it in the last twenty years. regards, tom lane