Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1smQS1-005cyQ-0G
	for pgsql-committers@arkaria.postgresql.org; Fri, 06 Sep 2024 04:20:01 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1smQRz-006Iho-F2
	for pgsql-committers@arkaria.postgresql.org; Fri, 06 Sep 2024 04:19:59 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1smQRz-006Ihg-7k
	for pgsql-committers@lists.postgresql.org; Fri, 06 Sep 2024 04:19:59 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1smQRt-000OLZ-Ms
	for pgsql-committers@lists.postgresql.org; Fri, 06 Sep 2024 04:19:58 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4864Jp6N2124535;
	Fri, 6 Sep 2024 00:19:51 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON
 EMPTY ste
In-reply-to: 
 <CA+HiwqFj4vD7kbTVrrDwVqNEdvUGkYo=+LT8nTN1DiODO4wWdw@mail.gmail.com>
References: <E1smPJm-000LOw-UP@gemulon.postgresql.org>
 <CA+HiwqHEFbjS5_dNBo39NmT-j7vTdmZn7HNM1ZN0-NjUfSBxFg@mail.gmail.com>
 <2123294.1725595759@sss.pgh.pa.us>
 <CA+HiwqFj4vD7kbTVrrDwVqNEdvUGkYo=+LT8nTN1DiODO4wWdw@mail.gmail.com>
Comments: In-reply-to Amit Langote <amitlangote09@gmail.com>
	message dated "Fri, 06 Sep 2024 13:18:01 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2124533.1725596391.1@sss.pgh.pa.us>
Date: Fri, 06 Sep 2024 00:19:51 -0400
Message-ID: <2124534.1725596391@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/2124534.1725596391%40sss.pgh.pa.us>
Precedence: bulk

Amit Langote <amitlangote09@gmail.com> writes:
> Yes, thanks for the note.  Will change the test case to test what are
> deparsing related changes in some other manner.

I usually prefer to test ruleutils.c by deparsing a suitable view.

			regards, tom lane