From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release
 tzcode20
In-reply-to: <31996.1563509161@sss.pgh.pa.us>
References: <E1hnsNp-0007u8-PD@gemulon.postgresql.org>
 <20190719035347.GJ1859@paquier.xyz> <31996.1563509161@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 19 Jul 2019 00:06:01 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2142.1563562594.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 19 Jul 2019 14:56:34 -0400
Message-ID: <2143.1563562594@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> This is causing a compilation warning on Windows:
> ...so I think your compiler has a point.  I shall complain to upstream.

The IANA folk want to fix it like this:

diff --git a/zic.c b/zic.c
index 8bf5628..a84703a 100644
--- a/zic.c
+++ b/zic.c
@@ -2145,7 +2145,7 @@ writezone(const char *const name, const char *const =
string, char version,
 		}
 		if (pass =3D=3D 1 && !want_bloat()) {
 		  utcnt =3D stdcnt =3D thisleapcnt =3D 0;
-		  thistimecnt =3D - locut - hicut;
+		  thistimecnt =3D - (locut + hicut);
 		  thistypecnt =3D thischarcnt =3D 1;
 		  thistimelim =3D thistimei;
 		}

I'm not quite convinced whether that will silence the warning, but
at least it's a bit less unreadable.

			regards, tom lane