From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <jdavis@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add functions pg_set_attribute_stats() and
 pg_clear_attribute_st
In-reply-to: <E1t3NIx-001xv3-6p@gemulon.postgresql.org>
References: <E1t3NIx-001xv3-6p@gemulon.postgresql.org>
Comments: In-reply-to Jeff Davis <jdavis@postgresql.org>
	message dated "Tue, 22 Oct 2024 22:24:42 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2144894.1729653514.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 22 Oct 2024 23:18:34 -0400
Message-ID: <2144895.1729653514@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2144895.1729653514%40sss.pgh.pa.us>
Precedence: bulk

Jeff Davis <jdavis@postgresql.org> writes:
> Add functions pg_set_attribute_stats() and pg_clear_attribute_stats().

A couple of buildfarm animals, eg [1], are mildly unhappy:

In file included from ../../../src/include/nodes/execnodes.h:37:0,
                 from ../../../src/include/catalog/indexing.h:19,
                 from attribute_stats.c:21:
attribute_stats.c: In function \342\200\230text_to_stavalues\342\200\231:
../../../src/include/nodes/miscnodes.h:54:15: warning: the comparison will=
 always evaluate as \342\200\230true\342\200\231 for the address of \342\2=
00\230escontext\342\200\231 will never be NULL [-Waddress]
  ((escontext) !=3D NULL && IsA(escontext, ErrorSaveContext) && \\
               ^
attribute_stats.c:636:6: note: in expansion of macro \342\200\230SOFT_ERRO=
R_OCCURRED\342\200\231
  if (SOFT_ERROR_OCCURRED(&escontext))
      ^

I think what we've done in other places is just to test
escontext.error_occurred directly, since the rest of the
macro is useless in this situation.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=3Drhinoc=
eros&dt=3D2024-10-23%2000%3A47%3A26&stg=3Dmake