Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eF2r5-00023I-Rr
	for pgsql-committers@arkaria.postgresql.org; Wed, 15 Nov 2017 18:56:11 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eF2r5-00035o-Ec
	for pgsql-committers@arkaria.postgresql.org; Wed, 15 Nov 2017 18:56:11 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eF2r5-00035e-7F
	for pgsql-committers@lists.postgresql.org; Wed, 15 Nov 2017 18:56:11 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eF2r2-0007f3-Is
	for pgsql-committers@postgresql.org; Wed, 15 Nov 2017 18:56:10 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id vAFIu5ep021510;
	Wed, 15 Nov 2017 13:56:05 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end
In-reply-to: <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net>
References: <E1eEzZG-0001kP-KI@gemulon.postgresql.org>
 <10176.1510764611@sss.pgh.pa.us>
 <575d6fa2-78d0-4456-8600-302fc35b2591@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 15 Nov 2017 13:03:45 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21508.1510772165.1@sss.pgh.pa.us>
Date: Wed, 15 Nov 2017 13:56:05 -0500
Message-ID: <21509.1510772165@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 11/15/2017 11:50 AM, Tom Lane wrote:
>> Andrew Dunstan <andrew@dunslane.net> writes:
>>> Add hooks for session start and session end

>> Buildfarm doesn't like this one bit :-(

> Strange, it worked when I tested. I'll look into it.

Looks to me like the problem is that the test can only work in "check"
mode, not "installcheck" mode, because in the latter case you don't
get to do preloaded libraries.

			regards, tom lane