Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1gmX6Z-0002YQ-Ii
	for pgsql-committers@arkaria.postgresql.org; Thu, 24 Jan 2019 04:59:07 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1gmX6Y-0001RN-7l
	for pgsql-committers@arkaria.postgresql.org; Thu, 24 Jan 2019 04:59:06 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gmX6Y-0001RG-29
	for pgsql-committers@lists.postgresql.org; Thu, 24 Jan 2019 04:59:06 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1gmX6T-0002SZ-JS
	for pgsql-committers@lists.postgresql.org; Thu, 24 Jan 2019 04:59:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0O4wsSd021694;
	Wed, 23 Jan 2019 23:58:55 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Detach constraints when partitions are detached
In-reply-to: <E1gmVI1-00071l-SO@gemulon.postgresql.org>
References: <E1gmVI1-00071l-SO@gemulon.postgresql.org>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Thu, 24 Jan 2019 03:02:49 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <21692.1548305934.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 23 Jan 2019 23:58:54 -0500
Message-ID: <21693.1548305934@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Detach constraints when partitions are detached

Hm ... it looks like this fails under -DRELCACHE_FORCE_RELEASE:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dprion&dt=3D2019-=
01-24%2003%3A58%3A02

Core was generated by `postgres: ec2-user regression [local] ALTER TABLE  =
                           '.
Program terminated with signal 11, Segmentation fault.
#0  0x00000000005f9413 in ATExecDetachPartition (rel=3Drel@entry=3D0x7f20d=
6fab080, name=3D<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.buil=
d/../pgsql/src/backend/commands/tablecmds.c:15116
15116			if (!idx->rd_index->indisprimary && !idx->rd_index->indisunique)
#0  0x00000000005f9413 in ATExecDetachPartition (rel=3Drel@entry=3D0x7f20d=
6fab080, name=3D<optimized out>) at /home/ec2-user/bf/root/HEAD/pgsql.buil=
d/../pgsql/src/backend/commands/tablecmds.c:15116
#1  0x0000000000605a95 in ATExecCmd (wqueue=3Dwqueue@entry=3D0x7ffe1afaea2=
8, tab=3Dtab@entry=3D0x1591a10, rel=3Drel@entry=3D0x7f20d6fab080, cmd=3D0x=
155ee08, lockmode=3Dlockmode@entry=3D8) at /home/ec2-user/bf/root/HEAD/pgs=
ql.build/../pgsql/src/backend/commands/tablecmds.c:4314
#2  0x0000000000607faf in ATRewriteCatalogs (lockmode=3D8, wqueue=3D0x7ffe=
1afaea28) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/=
commands/tablecmds.c:4028
#3  ATController (parsetree=3Dparsetree@entry=3D0x1542fc8, rel=3D<optimize=
d out>, cmds=3D<optimized out>, recurse=3D<optimized out>, lockmode=3Dlock=
mode@entry=3D8) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/ba=
ckend/commands/tablecmds.c:3694
#4  0x00000000006086cf in AlterTable (relid=3Drelid@entry=3D32016, lockmod=
e=3Dlockmode@entry=3D8, stmt=3Dstmt@entry=3D0x1542fc8) at /home/ec2-user/b=
f/root/HEAD/pgsql.build/../pgsql/src/backend/commands/tablecmds.c:3368
#5  0x0000000000792042 in ProcessUtilitySlow (pstate=3Dpstate@entry=3D0x15=
2ede8, pstmt=3Dpstmt@entry=3D0x1470b18, queryString=3DqueryString@entry=3D=
0x146fb78 "alter table idxpart detach partition idxpart1;", context=3Dcont=
ext@entry=3DPROCESS_UTILITY_TOPLEVEL, params=3Dparams@entry=3D0x0, queryEn=
v=3DqueryEnv@entry=3D0x0, completionTag=3DcompletionTag@entry=3D0x7ffe1afa=
efe0 "", dest=3D0x1470c10) at /home/ec2-user/bf/root/HEAD/pgsql.build/../p=
gsql/src/backend/tcop/utility.c:1120
#6  0x00000000007904d6 in standard_ProcessUtility (pstmt=3D0x1470b18, quer=
yString=3D0x146fb78 "alter table idxpart detach partition idxpart1;", cont=
ext=3DPROCESS_UTILITY_TOPLEVEL, params=3D0x0, queryEnv=3D0x0, dest=3D0x147=
0c10, completionTag=3D0x7ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pg=
sql.build/../pgsql/src/backend/tcop/utility.c:923
#7  0x000000000078dae5 in PortalRunUtility (portal=3D0x14d5dd8, pstmt=3D0x=
1470b18, isTopLevel=3D<optimized out>, setHoldSnapshot=3D<optimized out>, =
dest=3D<optimized out>, completionTag=3D0x7ffe1afaefe0 "") at /home/ec2-us=
er/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/pquery.c:1175
#8  0x000000000078e5f9 in PortalRunMulti (portal=3Dportal@entry=3D0x14d5dd=
8, isTopLevel=3DisTopLevel@entry=3Dtrue, setHoldSnapshot=3DsetHoldSnapshot=
@entry=3Dfalse, dest=3Ddest@entry=3D0x1470c10, altdest=3Daltdest@entry=3D0=
x1470c10, completionTag=3DcompletionTag@entry=3D0x7ffe1afaefe0 "") at /hom=
e/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/pquery.c:132=
8
#9  0x000000000078f292 in PortalRun (portal=3Dportal@entry=3D0x14d5dd8, co=
unt=3Dcount@entry=3D9223372036854775807, isTopLevel=3DisTopLevel@entry=3Dt=
rue, run_once=3Drun_once@entry=3Dtrue, dest=3Ddest@entry=3D0x1470c10, altd=
est=3Daltdest@entry=3D0x1470c10, completionTag=3DcompletionTag@entry=3D0x7=
ffe1afaefe0 "") at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/ba=
ckend/tcop/pquery.c:796
#10 0x000000000078b02d in exec_simple_query (query_string=3D0x146fb78 "alt=
er table idxpart detach partition idxpart1;") at /home/ec2-user/bf/root/HE=
AD/pgsql.build/../pgsql/src/backend/tcop/postgres.c:1215
#11 0x000000000078c362 in PostgresMain (argc=3D<optimized out>, argv=3Darg=
v@entry=3D0x149a548, dbname=3D0x149a2d8 "regression", username=3D<optimize=
d out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backend/tc=
op/postgres.c:4256
#12 0x00000000004805f8 in BackendRun (port=3D<optimized out>, port=3D<opti=
mized out>) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/backen=
d/postmaster/postmaster.c:4378
#13 BackendStartup (port=3D0x1490320) at /home/ec2-user/bf/root/HEAD/pgsql=
.build/../pgsql/src/backend/postmaster/postmaster.c:4069
#14 ServerLoop () at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/src/=
backend/postmaster/postmaster.c:1699
#15 0x0000000000713f60 in PostmasterMain (argc=3Dargc@entry=3D8, argv=3Dar=
gv@entry=3D0x146b6d0) at /home/ec2-user/bf/root/HEAD/pgsql.build/../pgsql/=
src/backend/postmaster/postmaster.c:1372
#16 0x0000000000481a63 in main (argc=3D8, argv=3D0x146b6d0) at /home/ec2-u=
ser/bf/root/HEAD/pgsql.build/../pgsql/src/backend/main/main.c:228


			regards, tom lane