Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkCQ1-0005Aw-4S for pgsql-committers@arkaria.postgresql.org; Wed, 05 Apr 2023 23:19:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkCPz-0003gv-Mr for pgsql-committers@arkaria.postgresql.org; Wed, 05 Apr 2023 23:19:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkCPz-0003gm-Fp for pgsql-committers@lists.postgresql.org; Wed, 05 Apr 2023 23:19:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkCPv-0001sL-LZ for pgsql-committers@lists.postgresql.org; Wed, 05 Apr 2023 23:19:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 335NJmjx2194724; Wed, 5 Apr 2023 19:19:48 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Don't initialize page in {vm,fsm}_extend(), not needed In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Wed, 05 Apr 2023 16:21:46 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2194722.1680736788.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 05 Apr 2023 19:19:48 -0400 Message-ID: <2194723.1680736788@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Don't initialize page in {vm,fsm}_extend(), not needed Various buildfarm members are complaining about under-braced initializations added by this commit. visibilitymap.c: In function \342\200\230vm_extend\342\200\231: visibilitymap.c:625:2: warning: missing braces around initializer [-Wmissi= ng-braces] PGAlignedBlock pg =3D {0}; ^ visibilitymap.c:625:2: warning: (near initialization for \342\200\230pg.da= ta\342\200\231) [-Wmissing-braces] freespace.c: In function \342\200\230fsm_extend\342\200\231: freespace.c:611:2: warning: missing braces around initializer [-Wmissing-b= races] PGAlignedBlock pg =3D {0}; ^ freespace.c:611:2: warning: (near initialization for \342\200\230pg.data\3= 42\200\231) [-Wmissing-braces] This is from buri, similar from curculio, dragonet, idiacanthus, xenodermus, etc regards, tom lane