Message-ID: <21c7267f-c27b-af5a-2c61-8777098587cb@gmail.com>
Date: Fri, 17 May 2024 13:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: pgsql: Update obsolete index scan TID comments.
To: Peter Geoghegan <pg@bowt.ie>, pgsql-committers@lists.postgresql.org
References: <E1rjnnt-003JwC-A9@gemulon.postgresql.org>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <E1rjnnt-003JwC-A9@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/21c7267f-c27b-af5a-2c61-8777098587cb%40gmail.com>
Precedence: bulk

Hello Peter,

12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.

I found one more obsolete comment mentioning xs_ctup:
             /*
              * For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
              * a virtual tuple that does not have the ctid column, so we have
              * to get the TID from xs_ctup.t_self.
              */
             IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;

             *current_tid = scan->xs_heaptid;

Maybe you would like to fix it too...

Best regards,
Alexander