Content-Type: multipart/mixed; boundary="------------U2uLiCMp5QYG10onvAKzFdAt"
Message-ID: <21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5@iki.fi>
Date: Thu, 12 Feb 2026 16:21:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Introduce pg_shmem_allocations_numa view
To: Tomas Vondra <tomas@vondra.me>,
 Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Christoph Berg <myon@debian.org>, Andres Freund <andres@anarazel.de>,
 Tomas Vondra <tomas.vondra@postgresql.org>,
 pgsql-hackers@lists.postgresql.org
References: <b54df21b-6595-4031-baf8-7c87851794c8@vondra.me>
 <aFuRoUieUVh+pMfZ@ip-10-97-1-34.eu-west-3.compute.internal>
 <aFu6tmQ7EVaaNV9K@msg.df7cb.de>
 <aFzadttaX+Qnb5s3@ip-10-97-1-34.eu-west-3.compute.internal>
 <aed7fd1f-4691-45d6-a002-6eba297443ca@vondra.me>
 <aF7V5hLDOc54QKfP@ip-10-97-1-34.eu-west-3.compute.internal>
 <132f85de-75c8-4e21-b875-b806596c9214@vondra.me>
 <aGNex9zyxmXqCHXy@ip-10-97-1-34.eu-west-3.compute.internal>
 <64e8ec11-6bb8-488b-abfc-8e67324a03fa@vondra.me>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <64e8ec11-6bb8-488b-abfc-8e67324a03fa@vondra.me>
Archived-At: 
 <https://www.postgresql.org/message-id/21cc7a48-99d9-4f69-9a3f-2c2de61ac8e5%40iki.fi>
Precedence: bulk

This is a multi-part message in MIME format.
--------------U2uLiCMp5QYG10onvAKzFdAt
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 01/07/2025 14:03, Tomas Vondra wrote:
> Thanks! Pushed, with both adjustments (link to kernel thread, adding the
> commit hash).
I just noticed that this (commit bf1119d74a: Add CHECK_FOR_INTERRUPTS 
into pg_numa_query_pages) made the function unusable in frontend 
programs, because CHECK_FOR_INTERRUPTS is server only. It's not used in 
frontend programs today, but it was placed in src/port/ with the idea 
that it could be.

That's pretty easy to fix by wrapping it in an "#ifndef FRONTEND" block, 
per attached.

- Heikki

--------------U2uLiCMp5QYG10onvAKzFdAt
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-Make-pg_numa_query_pages-work-in-frontend-programs.patch"
Content-Disposition: attachment;
 filename*0="0001-Make-pg_numa_query_pages-work-in-frontend-programs.patc";
 filename*1="h"
Content-Transfer-Encoding: base64

RnJvbSA5MmU2NmVhNWYxN2NhY2ZiMzQwOGQyYWY1MWI5ZDI0ZDQ0MTNjYzllIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBIZWlra2kgTGlubmFrYW5nYXMgPGhlaWtraS5saW5u
YWthbmdhc0Bpa2kuZmk+CkRhdGU6IFRodSwgMTIgRmViIDIwMjYgMTY6MTE6NDQgKzAyMDAK
U3ViamVjdDogW1BBVENIIDEvMV0gTWFrZSBwZ19udW1hX3F1ZXJ5X3BhZ2VzKCkgd29yayBp
biBmcm9udGVuZCBwcm9ncmFtcwoKSXQncyBjdXJyZW50bHkgb25seSB1c2VkIGluIHRoZSBz
ZXJ2ZXIsIGJ1dCBpdCB3YXMgcGxhY2VkIGluIHNyYy9wb3J0CndpdGggdGhlIGlkZWEgdGhh
dCBpdCBtaWdodCBiZSB1c2VmdWwgaW4gY2xpZW50IHByb2dyYW1zIHRvby4gSG93ZXZlciwK
aXQgd2lsbCBjdXJyZW50bHkgZmFpbCB0byBsaW5rIGlmIHVzZWQgaW4gYSBjbGllbnQgcHJv
Z3JhbSwgYmVjYXVzZQpDSEVDS19GT1JfSU5URVJSVVBUUygpIGlzIG5vdCB1c2FibGUgaW4g
Y2xpZW50IHByb2dyYW1zLiBGaXggdGhhdCBieQp3cmFwcGluZyBpdCBpbiAiI2lmbmRlZiBG
Uk9OVEVORCIuCi0tLQogc3JjL3BvcnQvcGdfbnVtYS5jIHwgMiArKwogMSBmaWxlIGNoYW5n
ZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9wb3J0L3BnX251bWEuYyBi
L3NyYy9wb3J0L3BnX251bWEuYwppbmRleCBkNTc0YTY4NmI0Mi4uODk1NDY2OTI3M2EgMTAw
NjQ0Ci0tLSBhL3NyYy9wb3J0L3BnX251bWEuYworKysgYi9zcmMvcG9ydC9wZ19udW1hLmMK
QEAgLTg3LDcgKzg3LDkgQEAgcGdfbnVtYV9xdWVyeV9wYWdlcyhpbnQgcGlkLCB1bnNpZ25l
ZCBsb25nIGNvdW50LCB2b2lkICoqcGFnZXMsIGludCAqc3RhdHVzKQogCQl1bnNpZ25lZCBs
b25nIGNvdW50X2NodW5rID0gTWluKGNvdW50IC0gbmV4dCwKIAkJCQkJCQkJCQlOVU1BX1FV
RVJZX0NIVU5LX1NJWkUpOwogCisjaWZuZGVmIEZST05URU5ECiAJCUNIRUNLX0ZPUl9JTlRF
UlJVUFRTKCk7CisjZW5kaWYKIAogCQkvKgogCQkgKiBCYWlsIG91dCBpZiBhbnkgb2YgdGhl
IGNodW5rcyBlcnJvcnMgb3V0IChyZXQ8MCkuIFdlIGlnbm9yZSAocmV0PjApCi0tIAoyLjQ3
LjMKCg==

--------------U2uLiCMp5QYG10onvAKzFdAt--