Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uBJ89-009A4S-KB for pgsql-committers@arkaria.postgresql.org; Sat, 03 May 2025 20:06:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uBJ87-00G8DB-Jt for pgsql-committers@arkaria.postgresql.org; Sat, 03 May 2025 20:06:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uBJ87-00G8D3-Cu for pgsql-committers@lists.postgresql.org; Sat, 03 May 2025 20:06:36 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uBJ85-0000Kv-2T; Sat, 03 May 2025 20:06:36 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 543K6WZA2202934; Sat, 3 May 2025 16:06:32 -0400 From: Tom Lane To: Alexander Korotkov cc: Alexander Korotkov , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback In-reply-to: References: <2199181.1746300894@sss.pgh.pa.us> Comments: In-reply-to Alexander Korotkov message dated "Sat, 03 May 2025 22:41:33 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <2202932.1746302792.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Sat, 03 May 2025 16:06:32 -0400 Message-ID: <2202933.1746302792@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alexander Korotkov writes: > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: >> You are aware that we are in release freeze, no? > I missed that. Should I revert this commit now? Yes, I think so. If you feel it's critical enough to go in on a release weekend, you should ask pgsql-release@ for an exception. regards, tom lane