Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5bCi-00064E-Or for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 16:30:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1c5bCi-0002Fr-6d for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Nov 2016 16:30:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5bCg-0002F3-U0 for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 16:30:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1c5bCZ-0007mB-W0 for pgsql-hackers@postgresql.org; Sat, 12 Nov 2016 16:30:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uACGUgxR022433; Sat, 12 Nov 2016 11:30:42 -0500 From: Tom Lane To: Andres Freund cc: Amit Kapila , Ashutosh Sharma , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. In-reply-to: <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de> References: <20160826220026.2fw6xj56qgd22wqi@alap3.anarazel.de> <20160830023140.tsesenk7roajx3ak@alap3.anarazel.de> <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 12 Nov 2016 05:04:08 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22431.1478968242.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 12 Nov 2016 11:30:42 -0500 Message-ID: <22432.1478968242@sss.pgh.pa.us> X-Pg-Spam-Score: -4.8 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Andres Freund writes: > Committed after simplifying the Makefile. While I have no particular objection to adding these tests, the commit log's claim that this will improve buildfarm testing is quite wrong. The buildfarm runs "make installcheck" not "make check" in contrib. What I'm actually seeing in the buildfarm reports is make -C pg_stat_statements installcheck make -C ../../src/test/regress pg_regress make -C ../../../src/port all make -C ../backend submake-errcodes make[4]: Nothing to be done for `submake-errcodes'. make -C ../../../src/common all make -C ../backend submake-errcodes make[4]: Nothing to be done for `submake-errcodes'. ../../src/test/regress/pg_regress --inputdir=3D. --bindir=3D'/Users/buildfa= rm/bf-data/HEAD/inst/bin' --port=3D5678 --temp-config ../../contrib/pg_st= at_statements/pg_stat_statements.conf --dbname=3Dcontrib_regression_pg_stat= _statements=20 (using postmaster on Unix socket, port 5678) =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D dropping database "contrib_regre= ssion_pg_stat_statements" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D NOTICE: database "contrib_regression_pg_stat_statements" does not exist, s= kipping DROP DATABASE =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D creating database "contrib_regre= ssion_pg_stat_statements" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D CREATE DATABASE ALTER DATABASE =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D running regression test queries = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D All 0 tests passed.=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D which is a rather blatant waste of cycles. I would suggest an explicit do-nothing installcheck rule rather than the hack you came up with here. regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers