Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 26A3D632E56 for ; Sun, 15 Feb 2009 13:22:00 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 56302-03 for ; Sun, 15 Feb 2009 13:21:57 -0400 (AST) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by mail.postgresql.org (Postfix) with ESMTP id 66321632AEF for ; Sun, 15 Feb 2009 13:21:57 -0400 (AST) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n1FHLssK022475; Sun, 15 Feb 2009 12:21:54 -0500 (EST) To: Magnus Hagander cc: pgsql-hackers@postgreSQL.org Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. In-reply-to: <499821F3.7050004@hagander.net> References: <20090122100948.89F977559ED@cvs.postgresql.org> <20643.1232666867@sss.pgh.pa.us> <499821F3.7050004@hagander.net> Comments: In-reply-to Magnus Hagander message dated "Sun, 15 Feb 2009 15:08:51 +0100" Date: Sun, 15 Feb 2009 12:21:54 -0500 Message-ID: <22474.1234718514@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200902/815 X-Sequence-Number: 134105 Magnus Hagander writes: > Tom Lane wrote: >> What makes more sense to me is to add a table to encnames.c that >> provides the gettext name of every encoding that we support. > Do you mean a separate table there, or should we add a new column to one > of the existing tables? Whichever seems to make more sense is fine with me. I just don't want add-an-encoding maintenance requirements spread across N different source files. regards, tom lane