Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1inYzt-0002QG-8P for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Jan 2020 02:17:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1inYzr-00044G-GV for pgsql-hackers@arkaria.postgresql.org; Sat, 04 Jan 2020 02:16:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1inYzr-000448-3z for pgsql-hackers@lists.postgresql.org; Sat, 04 Jan 2020 02:16:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1inYzi-0003FA-EN for pgsql-hackers@postgresql.org; Sat, 04 Jan 2020 02:16:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 0042GgeU022670; Fri, 3 Jan 2020 21:16:42 -0500 From: Tom Lane To: Peter Geoghegan cc: Robert Haas , Christoph Berg , PostgreSQL Hackers Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic. In-reply-to: References: <20200103170226.GB32629@msg.df7cb.de> <26339.1578072930@sss.pgh.pa.us> <20200103174839.GD32629@msg.df7cb.de> Comments: In-reply-to Peter Geoghegan message dated "Fri, 03 Jan 2020 17:32:10 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22668.1578104202.1@sss.pgh.pa.us> Date: Fri, 03 Jan 2020 21:16:42 -0500 Message-ID: <22669.1578104202@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Geoghegan writes: > Not sure if the specifics matter, but FWIW "make check-world" ended > with the following failure just now: > # Failed test 'offer multiple table choices' > # at t/010_tab_completion.pl line 105. > # Actual output was "\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K > \e[01;35mmytab\e[0m\e[K246\e[0m\e[K \r\npostgres=# select * from > mytab\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K > \e[01;35mmytab\e[0m\e[K246\e[0m\e[K \r\npostgres=# select * from > mytab" Huh. What readline or libedit version are you using, on what platform? I'm curious also what is your prevailing setting of TERM? (I've been wondering if the test doesn't need to force that to something standard. The buildfarm hasn't shown any signs of needing that, but manual invocations might be a different story.) regards, tom lane