Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbHP-0002kx-SM for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:34:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZbHO-00036h-Ec for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:34:42 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbHO-00036Y-5j for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:34:42 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbHL-0002mS-LK for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:34:41 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22UGYYQU228045; Wed, 30 Mar 2022 12:34:34 -0400 From: Tom Lane To: Andres Freund cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-reply-to: <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 30 Mar 2022 09:23:11 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <228043.1648658074.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Mar 2022 12:34:34 -0400 Message-ID: <228044.1648658074@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Because I forgot about cfbot when attaching the patch, cfbot actually ra= n with > it under this thread's cf entry. It does look like an improvement to me= : > https://cirrus-ci.com/task/6397292629458944?logs=3Dtest_world#L900 > We certainly can do better, but it's sufficiently better than what we ha= ve > right now. So I'd like to commit it? No objection here. >> Would we want to do this in all branches? I'd vote for yes, but ... > Unless somebody speaks in favor of doing this across branches, I'd just = go for > HEAD. +1 for HEAD only, especially if we think we might change it some more later. It seems possible this might break somebody's tooling if we drop it into minor releases. One refinement that comes to mind as I look at the patch is to distinguish between "check" and "installcheck". Not sure that's worthwhile, but not sure it isn't, either. regards, tom lane