From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Amit Kapila <amit.kapila16@gmail.com>,
        Ashutosh Sharma <ashu.coek88@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for
 extensions are allocated.
In-reply-to: <20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de>
References: <20160826220026.2fw6xj56qgd22wqi@alap3.anarazel.de>
 <CA+TgmoYmHD8CdW+8yh6A=i29Co-2xiiH3YBdBRxKFZ8TqP0V8A@mail.gmail.com>
 <CAA4eK1LaN1xXRgo2BxQGLYoXeNaQTZOoFOf6Qi19WfZkknZKgg@mail.gmail.com>
 <20160830023140.tsesenk7roajx3ak@alap3.anarazel.de>
 <CAA4eK1JOjkdXYtHxh=2aDK4VgDtN-LNGKY_YqX0N=YEvuzQVWg@mail.gmail.com>
 <CAA4eK1Jt5fYe2jnQ7XXDrpy3Z4W80UYhQa9SvCyXz+7mcoN8Gw@mail.gmail.com>
 <CAE9k0P=tew0UXETJfM5WQjqNS0k7xYZEFWMZCY8ZuEqRSD1uUA@mail.gmail.com>
 <CAA4eK1LJRtV=jBa46F6+=s7cf-x7ajFAraYBdAxaCjZ0m_FQ0w@mail.gmail.com>
 <20161112130408.kfsxcbkqo2b3nvuq@alap3.anarazel.de>
 <22432.1478968242@sss.pgh.pa.us>
 <20161112163508.5uqlaozeyr3l56ae@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Sat, 12 Nov 2016 08:35:08 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22898.1478968932.1@sss.pgh.pa.us>
Date: Sat, 12 Nov 2016 11:42:12 -0500
Message-ID: <22899.1478968932@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2016-11-12 11:30:42 -0500, Tom Lane wrote:
>> which is a rather blatant waste of cycles. I would suggest an explicit
>> do-nothing installcheck rule rather than the hack you came up with here.

> I had that at first, but that generates a warning about overwriting the
> makefile target - which afaics cannot be fixed.

Hm.  What about inventing an additional macro NO_INSTALLCHECK that
prevents pgxs.mk from generating an installcheck rule?  It's not
like we don't have similar issues elsewhere, eg contrib/sepgsql.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers