From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter_e@gmx.net>,
        Michael Paquier <michael.paquier@gmail.com>,
        Fujii Masao <masao.fujii@gmail.com>,
        Fujii Masao <fujii@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
In-reply-to: <20190521004717.qsktdsugj3shagco@alap3.anarazel.de>
References: <26460.1558366996@sss.pgh.pa.us>
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
 <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
 <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
 <23559.1558374415@sss.pgh.pa.us>
 <20190520180027.zyxosts5yrf2i7mh@alap3.anarazel.de>
 <24497.1558375780@sss.pgh.pa.us>
 <20190520203505.zoeitjlehqypgx26@alap3.anarazel.de>
 <21766.1558397960@sss.pgh.pa.us>
 <20190521004717.qsktdsugj3shagco@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 20 May 2019 17:47:17 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22940.1558399941.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 20 May 2019 20:52:21 -0400
Message-ID: <22941.1558399941@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-20 20:19:20 -0400, Tom Lane wrote:
>> The other thing I had to do below was to suppress "NOTICE: database
>> "regression" does not exist, skipping".  The added createdb is a
>> mighty expensive and grotty way to do that, but I didn't immediately
>> see a better one.

> Hm. Perhaps we ought to just have pg_regress set client_min_messages to
> something less noisy when running DROP DATABASE? I don't think any
> pg_regress caller benefits from having it.

Yeah, the first thing I tried was

-	psql_command("postgres", "DROP DATABASE IF EXISTS \"%s\"", dbname);
+	psql_command("postgres", "SET client_min_messages =3D warning; DROP DATA=
BASE IF EXISTS \"%s\"", dbname);

in pg_regress.c, but that fails with "ERROR:  DROP DATABASE cannot run
inside a transaction block".  It's probably possible to improve this
but it'll take a bit of surgery.

			regards, tom lane