From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Address set of issues with errno handling
In-reply-to: <20180804121834.GG20967@paquier.xyz>
References: <E1fXHAd-0004Qv-8y@gemulon.postgresql.org>
 <31797.1533326676@sss.pgh.pa.us> <20180804121834.GG20967@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sat, 04 Aug 2018 21:18:34 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22990.1533396088.1@sss.pgh.pa.us>
Date: Sat, 04 Aug 2018 11:21:28 -0400
Message-ID: <22991.1533396088@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Aug 03, 2018 at 04:04:36PM -0400, Tom Lane wrote:
>> You need to go back and add the pre-clearing of errno in each of these
>> places, otherwise the added code is basically useless.

> I looked at all code paths enforcing ENOSPC on write() calls, and
> attached is a patch to address this issue for all of them.  What do you
> think?  I can of course get that addressed before the next set of minor
> releases.

That looks good as far as it goes.  I didn't cross-check that you
hit everyplace that needs this, but if you grepped for references to
ENOSPC then you presumably found them all.

IMO, it's OK to push this this weekend if you have time.

			regards, tom lane