Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
 <1252480.1631829409@sss.pgh.pa.us> <YUPOfPqqbvuZeouS@paquier.xyz>
 <YUPlCVfPi1urH/iN@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
Message-ID: <22a1c05f-a931-ba46-fb88-ac9680e7816a@dunslane.net>
Date: Fri, 17 Sep 2021 15:18:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <YUPlCVfPi1urH/iN@paquier.xyz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Archived-At: 
 <https://www.postgresql.org/message-id/22a1c05f-a931-ba46-fb88-ac9680e7816a%40dunslane.net>
Precedence: bulk


On 9/16/21 8:44 PM, Michael Paquier wrote:
> On Fri, Sep 17, 2021 at 08:08:44AM +0900, Michael Paquier wrote:
>> I am not completely sure what's going on here yet, so I'll just switch
>> the test to be skipped when Msys is involved for now.  That should be
>> enough to bring back those machines to green.
> So, after drinking down a coffee, I have remembered the difference
> between the Msys and native perls when it comes to IPC::Run:
> - Msys perl generates \r\n.
> - Native perl generates \n.
>
> We have already a couple of places where we filter that out, like
> PostgresNode::psql or slurp_file.  But we are missing some spots
> before calling like() for outputs generated by IPC::Run.  I have 
> tracked all those places with the attached, and I think that this
> should take care of the failure seen here while preventing future
> problems.
>
> Any thoughts?


The fixups for command_checks_all should go before the loops, not inside
them.


I would probably add a single line like this just after the call that
checks the status:


   foreach ($stderr, $stdout) { s/\r\n/\n/g if $Config{osname} eq 'msys'; }


although maybe perltidy would reformat that.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com