Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbeW-0004Eg-4M for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:58:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZbeV-0002Rs-0J for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 16:58:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbeU-0002Rj-Ns for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:58:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZbeS-0001jq-Hb for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 16:58:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22UGwQpc230839; Wed, 30 Mar 2022 12:58:26 -0400 From: Tom Lane To: Andres Freund cc: Robert Haas , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-reply-to: <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 30 Mar 2022 09:50:39 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <230837.1648659506.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 30 Mar 2022 12:58:26 -0400 Message-ID: <230838.1648659506@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-03-30 12:34:34 -0400, Tom Lane wrote: >> One refinement that comes to mind as I look at the patch is to distingu= ish >> between "check" and "installcheck". Not sure that's worthwhile, but no= t >> sure it isn't, either. > As it's just about "free" to do so, I see no reason not to go for showin= g that > difference. How about: > echo "+++ (tap|regress|isolation) [install-]check in $(subdir) +++" && \ WFM. > I see no reason to distinguish the PGXS / non-PGXs tap installcheck case= s? Agreed. > Random aside: Am I the only one bothered by a bunch of places in > Makefile.global.in quoting like > $(MAKE) -C '$(top_builddir)' DESTDIR=3D'$(abs_top_builddir)'/tmp_insta= ll install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1 > and > rm -rf '$(CURDIR)'/tmp_check && > etc Don't we need that to handle, say, build paths with spaces in them? Admittedly we're probably not completely clean for such paths, but that's not an excuse to break the places that do it right. (I occasionally think about setting up a BF animal configured like that, but haven't tried yet.) regards, tom lane