Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZrkP-0004o1-Cc for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 10:09:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZrkO-0005fl-7t for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 10:09:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZrkO-0005fX-0q for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 10:09:44 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZrkK-0003Zo-NW for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 10:09:43 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 1A435240008; Thu, 31 Mar 2022 10:09:37 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------mPoihsvGfv0G70YXaIeKnB3A" Message-ID: <230c42b8-5758-3616-b4fd-df9191f0c273@dunslane.net> Date: Thu, 31 Mar 2022 06:09:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Make PostgreSQL::Test::Cluster compatible with all live branches Content-Language: en-US To: Tom Lane Cc: pgsql-committers@lists.postgresql.org References: <474104.1648685981@sss.pgh.pa.us> <393B4FCB-1A6D-4993-B914-7E20A54863BE@dunslane.net> <479467.1648689140@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <479467.1648689140@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------mPoihsvGfv0G70YXaIeKnB3A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/22 21:12, Tom Lane wrote: > Andrew Dunstan writes: >>> On Mar 30, 2022, at 8:19 PM, Tom Lane wrote: >>> I think this means that its old Perl version misinterprets >>> use parent -norequire, qw(PostgreSQL::Test::Cluster); >>> as a request to include "parent.pm". Is there a more >>> backwards-compatible way to spell that? >> Not that I know of. Googling tells me it was a core module from 5.10.1. I can revert tomorrow if necessary :-( I must have been half asleep when I posted this. There are three ways out of this that I can see: . carry a copy of parent.pm in src/test/perl (It's very small) . use the older and heavier 'base' module which goes back to 5.004, and does much the same thing (and a lot more) . just do directly what parent.pm's import() does, as in the attached, which I have tested down to version 10. On the whole I think I prefer the last. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com --------------mPoihsvGfv0G70YXaIeKnB3A Content-Type: text/x-patch; charset=UTF-8; name="cluster-parent-fix.patch" Content-Disposition: attachment; filename="cluster-parent-fix.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L0NsdXN0ZXIucG0g Yi9zcmMvdGVzdC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9DbHVzdGVyLnBtCmluZGV4IGZhMGVm MTJkNzIuLjFiZmJiNzViMDEgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNR TC9UZXN0L0NsdXN0ZXIucG0KKysrIGIvc3JjL3Rlc3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3Qv Q2x1c3Rlci5wbQpAQCAtMjkxOCw3ICsyOTE4LDEwIEBAIHN1YiBjb3JydXB0X3BhZ2VfY2hl Y2tzdW0KIAogcGFja2FnZSBQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyOjpWXzExOyAjIyBu byBjcml0aWMgKFByb2hpYml0TXVsdGlwbGVQYWNrYWdlcykKIAotdXNlIHBhcmVudCAtbm9y ZXF1aXJlLCBxdyhQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyKTsKKyMgcGFyZW50LnBtIGlz IG5vdCBwcmVzZW50IGluIGFsbCBwZXJsIHZlcnNpb25zIGJlZm9yZSA1LjEwLjEsIHNvIGlu c3RlYWQKKyMgZG8gZGlyZWN0bHkgd2hhdCBpdCB3b3VsZCBkbyBmb3IgdGhpczoKKyMgdXNl IHBhcmVudCAtbm9yZXF1aXJlLCBxdyhQb3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyKTsKK3B1 c2ggQFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXI6OlZfMTE6OklTQSwgJ1Bvc3RncmVTUUw6 OlRlc3Q6OkNsdXN0ZXInOwogCiAjIGh0dHBzOi8vd3d3LnBvc3RncmVzcWwub3JnL2RvY3Mv MTEvcmVsZWFzZS0xMS5odG1sCiAKQEAgLTI5NDUsNyArMjk0OCw4IEBAIHN1YiBpbml0CiAK IHBhY2thZ2UgUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlcjo6Vl8xMDsgIyMgbm8gY3JpdGlj IChQcm9oaWJpdE11bHRpcGxlUGFja2FnZXMpCiAKLXVzZSBwYXJlbnQgLW5vcmVxdWlyZSwg cXcoUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlcjo6Vl8xMSk7CisjIHVzZSBwYXJlbnQgLW5v cmVxdWlyZSwgcXcoUG9zdGdyZVNRTDo6VGVzdDo6Q2x1c3Rlcjo6Vl8xMSk7CitwdXNoIEBQ b3N0Z3JlU1FMOjpUZXN0OjpDbHVzdGVyOjpWXzEwOjpJU0EsICdQb3N0Z3JlU1FMOjpUZXN0 OjpDbHVzdGVyOjpWXzExJzsKIAogIyBodHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9kb2Nz LzEwL3JlbGVhc2UtMTAuaHRtbAogCg== --------------mPoihsvGfv0G70YXaIeKnB3A--