From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock
 region.
In-reply-to: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
References: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 02 Nov 2024 16:08:47 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2317335.1730601176.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 02 Nov 2024 22:32:56 -0400
Message-ID: <2317336.1730601176@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2317336.1730601176%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> Move I/O before the index_update_stats() buffer lock region.

In branches before 17, this commit is causing some compilers
to complain:

index.c: In function 'index_update_stats':
index.c:2913:24: warning: 'relpages' may be used uninitialized in this fun=
ction [-Wmaybe-uninitialized]
   if (rd_rel->relpages !=3D (int32) relpages)
       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~

I'm seeing that with RHEL8's gcc 8.5.0, and trawling the buildfarm
shows at least 40 animals similarly unhappy.  (I noticed this because
mamba, which is using -Werror, is actually failing.)

			regards, tom lane