Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1t7R40-001szp-2X
	for pgsql-committers@arkaria.postgresql.org; Sun, 03 Nov 2024 03:14:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1t7R3y-009p7I-29
	for pgsql-committers@arkaria.postgresql.org; Sun, 03 Nov 2024 03:14:02 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1t7R3x-009p7A-RP
	for pgsql-committers@lists.postgresql.org; Sun, 03 Nov 2024 03:14:02 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1t7R3v-004DFm-J4
	for pgsql-committers@lists.postgresql.org; Sun, 03 Nov 2024 03:14:00 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4A33Dv3Z2322264;
	Sat, 2 Nov 2024 23:13:57 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock
 region.
In-reply-to: <20241103031027.09.nmisch@google.com>
References: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
 <2317336.1730601176@sss.pgh.pa.us> <20241103031027.09.nmisch@google.com>
Comments: In-reply-to Noah Misch <noah@leadboat.com>
	message dated "Sat, 02 Nov 2024 20:10:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2322262.1730603637.1@sss.pgh.pa.us>
Date: Sat, 02 Nov 2024 23:13:57 -0400
Message-ID: <2322263.1730603637@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/2322263.1730603637%40sss.pgh.pa.us>
Precedence: bulk

Noah Misch <noah@leadboat.com> writes:
> On Sat, Nov 02, 2024 at 10:32:56PM -0400, Tom Lane wrote:
>> In branches before 17, this commit is causing some compilers
>> to complain:

> Hopefully now the code won't fool any compiler.

I saw your commit, and I'm content with it, but did you figure
out why the warning only appears pre-17?  (At least, that's
what I got locally.)

			regards, tom lane