Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFWrF-0007h2-9T for pgsql-committers@arkaria.postgresql.org; Fri, 17 Nov 2017 02:58:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eFWrE-0005Rq-ML for pgsql-committers@arkaria.postgresql.org; Fri, 17 Nov 2017 02:58:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eFWrE-0005Rg-Er for pgsql-committers@lists.postgresql.org; Fri, 17 Nov 2017 02:58:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1eFWrB-000790-Ng for pgsql-committers@postgresql.org; Fri, 17 Nov 2017 02:58:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id vAH2wER0023340; Thu, 16 Nov 2017 21:58:14 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Remove BufFile's isTemp flag. In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Fri, 17 Nov 2017 02:02:03 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23338.1510887494.1@sss.pgh.pa.us> Date: Thu, 16 Nov 2017 21:58:14 -0500 Message-ID: <23339.1510887494@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andres Freund writes: > Remove BufFile's isTemp flag. > The isTemp flag controls whether buffile.c chops BufFile data up into > 1GB segments on disk. Since it was badly named and always true, get > rid of it. [ squint... ] That used to have an actual purpose connected to transaction-abort cleanup, IIRC. It disturbs me that this seems to have been lost. regards, tom lane