Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYsLr-0006xf-GB for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 16:04:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYsLq-0003rn-F0 for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Oct 2021 16:04:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYsLq-0003rc-6h for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 16:04:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYsLn-0004pP-50 for pgsql-hackers@lists.postgresql.org; Fri, 08 Oct 2021 16:04:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 198G3f5J234638; Fri, 8 Oct 2021 12:03:41 -0400 From: Tom Lane To: Daniel Gustafsson cc: Noah Misch , Postgres hackers , Craig Ringer Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. In-reply-to: <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> Comments: In-reply-to Daniel Gustafsson message dated "Fri, 08 Oct 2021 10:03:42 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <234636.1633709021.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 08 Oct 2021 12:03:41 -0400 Message-ID: <234637.1633709021@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Daniel Gustafsson writes: > On 8 Oct 2021, at 06:24, Noah Misch wrote: >> That's obvious from "cpanm install IPC::Run". Surely if any other non-= core >> module were allowed, the recipe would list it in a similar way. > The proposed changes talks about with core modules are allowed to use, I= think > that's a different thing. The distinction between core and non-core mod= ules > may not be known/clear to people who haven't used Perl in the past. Yeah, I don't really think that this recipe makes it plain that we have a policy. It certainly fails to explain that you're allowed to use additional modules if you're willing to skip the relevant tests. > This README isn't primarily targeting committers though IMO, but new dev= elopers > onboarding onto postgres who are trying to learn the dev environment. Right. >> If there's something to change, it's improving the actual recipe: > That we should do as well. You're not going to get far with "improving the recipe", because it's just not possible. To check this, I installed perlbrew on a Fedora 34 machine, and found that it actually can install a mostly-working 5.8.3 (nice!). But as I suspected earlier, it can't reproduce the old module configuration: $ cpanm install Test::More@0.87 --> Working on install Fetching http://www.cpan.org/authors/id/D/DA/DAGOLDEN/install-0.01.tar.gz = ... OK =3D=3D> Found dependencies: ExtUtils::MakeMaker --> Working on ExtUtils::MakeMaker Fetching http://www.cpan.org/authors/id/B/BI/BINGOS/ExtUtils-MakeMaker-7.6= 2.tar.gz ... OK Configuring ExtUtils-MakeMaker-7.62 ... OK Building and testing ExtUtils-MakeMaker-7.62 ... OK Successfully installed ExtUtils-MakeMaker-7.62 (upgraded from 6.17) Configuring install-0.01 ... OK Building and testing install-0.01 ... OK Successfully installed install-0.01 ! Finding Test::More (=3D=3D 0.87) on cpanmetadb failed. Found Test::More 1.302188 which doesn't satisfy =3D=3D 0.87. 2 distributions installed Not only is that a fail on Test::More itself, but as un-asked-for side effects, it upgraded ExtUtils::MakeMaker to current, and installed a module that should not have been there (which kinda defeats the point of the exercise). I did find I could install IPC::Run 0.79, which matches prairiedog's version of that module: $ cpanm install IPC::Run@0.79 = install is up to date. (0.01) ! Finding IPC::Run (=3D=3D 0.79) on cpanmetadb failed. --> Working on IPC::Run Fetching http://cpan.metacpan.org/authors/id/R/RS/RSOD/IPC-Run-0.79.tar.gz= ... OK Configuring IPC-Run-0.79 ... OK Building and testing IPC-Run-0.79 ... OK Successfully installed IPC-Run-0.79 1 distribution installed However, this just reflects the fact that prairiedog's installation is itself a bit Frankensteinan. What it has for Test::More and IPC::Run are just the oldest versions I could find on CPAN back in 2017 when I built that installation. I can't claim that they have any historical relevance. They are, however, a lot more likely to still be duplicatable from current CPAN than actually-old versions. So while this recipe is a lot more useful than I thought, it can't entirely reproduce the Perl environment of older buildfarm members. I think we really ought to document that. I also think it is useful to explicitly state the policy and then give this recipe as one way to (partially) test against the policy. regards, tom lane