From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Fujii Masao <masao.fujii@gmail.com>, Fujii Masao <fujii@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
In-reply-to: <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
References: <E1hSk9C-0002hH-Vp@gemulon.postgresql.org>
 <26460.1558366996@sss.pgh.pa.us>
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
 <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
 <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 20 May 2019 09:49:08 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <23558.1558374415.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 20 May 2019 13:46:55 -0400
Message-ID: <23559.1558374415@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-21 01:43:35 +0900, Fujii Masao wrote:
>> Thanks for the commit! And sorry, make check-world took very long time
>> and has just finished right now in my env... I'd like to confirm that
>> make check-world reports no error just in case.

> make -j16 -s && make -Otarget -j10 -s check-world && echo success || ech=
o fail

> makes that much more bearable, by running the slow TAP tests in
> parallel. Doesn't work < 10 though.

Yeah, parallelization makes all the difference in the world, assuming
you have a multi-core machine.  You can parallelize within TAP suites
too.  I use

make -s check-world -j4 PROVE_FLAGS=3D'-j4 --quiet --nocolor --nocount'

on an 8-core machine, and get typical runtimes under 2m30s.

If there were a way to get prove to be absolutely quiet (its --quiet is
a joke unfortunately), I'd lobby for a switch to make pg_regress quiet
too.  The amount of useless noise this recipe generates is annoying,
and tends to make it hard to find where the actual error is when
there is one.

			regards, tom lane