Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1u0wjR-00AztD-Qf
	for pgsql-committers@arkaria.postgresql.org; Sat, 05 Apr 2025 06:10:17 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1u0wjQ-009cyU-Hb
	for pgsql-committers@arkaria.postgresql.org; Sat, 05 Apr 2025 06:10:16 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u0wjQ-009cyL-A2
	for pgsql-committers@lists.postgresql.org; Sat, 05 Apr 2025 06:10:16 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1u0wjN-003UZj-23;
	Sat, 05 Apr 2025 06:10:15 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 5356AA4r2408469;
	Sat, 5 Apr 2025 02:10:10 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
cc: Nathan Bossart <nathan@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent redeclaration of typedef TocEntry.
In-reply-to: <202504042140.qo66ggw6wzsz@alvherre.pgsql>
References: <202504042140.qo66ggw6wzsz@alvherre.pgsql>
Comments: In-reply-to =?utf-8?Q?=C3=81lvaro?= Herrera
 <alvherre@alvh.no-ip.org>
	message dated "Fri, 04 Apr 2025 23:40:48 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2408467.1743833410.1@sss.pgh.pa.us>
Date: Sat, 05 Apr 2025 02:10:10 -0400
Message-ID: <2408468.1743833410@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/2408468.1743833410%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org> writes:
> ... AFAICS we could move both DefnDumperPtr and
> DataDumperPtr typedefs to pg_backup_archiver.h, together with struct
> _tocEntry (the only place where they are used), and we'd have less of a
> mess here.  Then we don't need struct TocEntry in pg_backup.h anymore.

+1 for this simplification.

			regards, tom lane