To: Alvaro Herrera <alvherre@commandprompt.com>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Make new strings more alike previously existing messages. 
In-reply-to: <20090413210336.300427540F4@cvs.postgresql.org> 
References: <20090413210336.300427540F4@cvs.postgresql.org>
Comments: In-reply-to alvherre@postgresql.org (Alvaro Herrera)
	message dated "Mon, 13 Apr 2009 21:03:36 -0000"
Date: Mon, 13 Apr 2009 18:57:00 -0400
Message-ID: <24097.1239663420@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

alvherre@postgresql.org (Alvaro Herrera) writes:
> Make new strings more alike previously existing messages.

This patch changed the meaning of one of the messages:

*************** main(int argc, char **argv)
*** 316,322 ****
  	/* Can't do single-txn mode with multiple connections */
  	if (opts->single_txn && opts->number_of_jobs > 1)
  	{
! 		fprintf(stderr, _("%s: cannot specify both --single-transaction and multiple jobs\n"),
  				progname);
  		exit(1);
  	}
--- 316,322 ----
  	/* Can't do single-txn mode with multiple connections */
  	if (opts->single_txn && opts->number_of_jobs > 1)
  	{
! 		fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"),
  				progname);
  		exit(1);
  	}

As the comment and the code itself show, "-j 1" works just fine with
--single-transaction.  The original wording reflected that, the new does
not.

Maybe this amount of imprecision is acceptable, but "make it look more
like the other messages" doesn't seem to me like enough justification.

			regards, tom lane