From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Make heap TID a tiebreaker nbtree index column.
In-reply-to: 
 <CAH2-WzkCQ_MtKeOpzozj7QhhgP1unXsK8o9DMAFvDqQFEPpkYQ@mail.gmail.com>
References: <E1h6eep-0001Mw-Vd@gemulon.postgresql.org>
 <CAH2-WzmFdW-e9+uG5BqzuW7YWBdL9=Vrwgmt5p6vndCeKJ5Z4w@mail.gmail.com>
 <13999.1553105283@sss.pgh.pa.us>
 <CAH2-Wznu+i765yrRcpKC0m9N2LEFWg=stjF73U7XmakSXWDDAg@mail.gmail.com>
 <CAH2-WzkCQ_MtKeOpzozj7QhhgP1unXsK8o9DMAFvDqQFEPpkYQ@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Wed, 20 Mar 2019 12:12:07 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24276.1553114810.1@sss.pgh.pa.us>
Date: Wed, 20 Mar 2019 16:46:50 -0400
Message-ID: <24277.1553114810@sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Wed, Mar 20, 2019 at 11:30 AM Peter Geoghegan <pg@bowt.ie> wrote:
>> Your work on test stability probably eliminated 98% of the problems.
>> It's still early, but the buildfarm is mostly fine.

> batfish just had a similar failure, this time in foreign_data -- two
> lines of "DETAIL" output appear in opposite-of-expected order.
> Obviously that's unstable in a way that it wasn't before now, since
> every other animal doesn't have that problem.

Yeah.  My opinion is that we should just qsort the list of targets
during DROP OWNED and be done with this.  I'll post a patch shortly.

In the meantime, would you mind cleaning this up:

nbtxlog.c: In function 'btree_xlog_split':
nbtxlog.c:269: warning: 'newitem' may be used uninitialized in this function
nbtxlog.c:269: note: 'newitem' was declared here
nbtxlog.c:271: warning: 'newitemsz' may be used uninitialized in this function
nbtxlog.c:271: note: 'newitemsz' was declared here


			regards, tom lane