From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Fujii Masao <masao.fujii@gmail.com>, Fujii Masao <fujii@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
In-reply-to: <20190520180027.zyxosts5yrf2i7mh@alap3.anarazel.de>
References: <E1hSk9C-0002hH-Vp@gemulon.postgresql.org>
 <26460.1558366996@sss.pgh.pa.us>
 <CAHGQGwEvM9X66Ni4OKv4dOQQddw7z=cNUxnG=wEv84sqj9t_ig@mail.gmail.com>
 <20190520163652.l7ibpe52pbq6lecc@alap3.anarazel.de>
 <CAHGQGwEixkoMJy4JHUvBdM0MacR1_h=wmE43KTOTErpA2Z5P0w@mail.gmail.com>
 <20190520164908.t653bdbfjcn3d35p@alap3.anarazel.de>
 <23559.1558374415@sss.pgh.pa.us>
 <20190520180027.zyxosts5yrf2i7mh@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 20 May 2019 11:00:27 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24496.1558375780.1@sss.pgh.pa.us>
Date: Mon, 20 May 2019 14:09:40 -0400
Message-ID: <24497.1558375780@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2019-05-20 13:46:55 -0400, Tom Lane wrote:
>> If there were a way to get prove to be absolutely quiet (its --quiet is
>> a joke unfortunately), I'd lobby for a switch to make pg_regress quiet
>> too.  The amount of useless noise this recipe generates is annoying,
>> and tends to make it hard to find where the actual error is when
>> there is one.

> Indeed. Couldn't we just invent that on our end? I.e. in our prove
> invocation, just redirect the output?

What I'd like, for both prove and pg_regress, is to print something
about failing tests and otherwise be quiet.  Simple redirection won't
do that.  Plus it'd be hard to fit that in with the case where you
don't want it to be quiet.

> The most annoying noise imo is the pg_upgrade test. The set -x and the
> fact that it resets MAKEFLAGS makes that pretty annoying.

Agreed, that could be improved independently of other things.

			regards, tom lane