Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0gd-0003fR-Sq for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:16:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJ0gc-0007jE-Is for pgsql-hackers@arkaria.postgresql.org; Sat, 12 Feb 2022 22:16:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0gc-0007j3-9n for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 22:16:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ0gZ-0004Np-Me for pgsql-hackers@lists.postgresql.org; Sat, 12 Feb 2022 22:16:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21CMG3HV2460219; Sat, 12 Feb 2022 17:16:03 -0500 From: Tom Lane To: Robert Haas cc: Andres Freund , Michael Paquier , PostgreSQL Hackers Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. In-reply-to: References: <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> Comments: In-reply-to Robert Haas message dated "Sat, 12 Feb 2022 17:10:32 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2460217.1644704163.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 12 Feb 2022 17:16:03 -0500 Message-ID: <2460218.1644704163@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Sat, Feb 12, 2022 at 5:09 PM Andres Freund wrote= : >> I don't think there's an actual configure check for the lz4 binary? Loo= ks like >> a static assignment in src/Makefile.global.in to me. > Oh. That seems kind of dumb. It looks to me like somebody figured it didn't need any more support than gzip/bzip2, which is wrong on a couple of grounds: * hardly any modern platforms lack those, unlike lz4 * we don't invoke either one of them during testing, only when you explicitly ask to make a compressed tarball I think adding an explicit PGAC_PATH_PROGS would be worth the cycles. regards, tom lane