From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
        laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-reply-to: <20190313022159.GR13812@paquier.xyz>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
 <20190313022159.GR13812@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Wed, 13 Mar 2019 11:21:59 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24812.1552447002.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 12 Mar 2019 23:16:42 -0400
Message-ID: <24813.1552447002@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Mar 12, 2019 at 07:55:14PM +0000, Tom Lane wrote:
>> Add support for hyperbolic functions, as well as log10().

> jacana is not a fan of this commit, and failed on float8:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Djacana&dt=3D20=
19-03-13%2000%3A00%3A27
> @@ -476,7 +476,7 @@
> SELECT asinh(float8 '0');
>  asinh
> -------
> -     0
> +    -0
> (1 row)

Yeah.  I warned Laetitia about not testing corner cases, but
it hadn't occurred to me that zero might be a corner case :-(

I'm inclined to leave it as-is for a day or so and see if any
other failures turn up, before deciding what to do about it.

			regards, tom lane