From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Noah Misch <noah@leadboat.com>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: aix: No need to use mkldexport when we want to export all
 symbol
In-reply-to: <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de>
References: <E1oWpzF-002EG4-AG@gemulon.postgresql.org>
 <325593.1662783266@sss.pgh.pa.us>
 <89D645BA-FF97-4516-A21D-9FC4A4B31F8C@anarazel.de>
 <20220910043749.koidc5k4j5dxo3if@awork3.anarazel.de>
 <20220910052741.t7w7csyrggwus2ze@awork3.anarazel.de>
 <338810.1662787972@sss.pgh.pa.us>
 <20220910055736.htsr5juo3ldlay2l@awork3.anarazel.de>
 <20220910081944.oiayp5lky3kv2o43@awork3.anarazel.de>
 <20220911181925.ygxbync3uk5ezcic@awork3.anarazel.de>
 <20220913182530.4yq35ralujjsv2k3@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 13 Sep 2022 11:25:30 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2490843.1663123546.1@sss.pgh.pa.us>
Date: Tue, 13 Sep 2022 22:45:46 -0400
Message-ID: <2490844.1663123546@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2490844.1663123546%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> So we could work around the xlc 12.1 issue with something like the attached
> patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will
> have to wait a while to see more

Shouldn't that be more like

+  if test "$pgac_cv_prog_CC_cflags__qvisibility_hidden" != "yes"; then
+    CFLAGS_SL_MODULE='$CFLAGS_SL_MODULE -Wl,-b,expfull'
+  fi

to avoid losing whatever we found out before that?

> I think it'd be considerably better to just not support xlc < 13.1 though.

A three-line patch doesn't seem like an unreasonable thing to carry,
at least till these systems go out of support.  We've jumped through
much higher hoops in the past to support niche platforms.

			regards, tom lane