Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ6Fv-0008FU-Qn for pgsql-hackers@arkaria.postgresql.org; Sun, 13 Feb 2022 04:12:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nJ6Fu-0001o2-Nd for pgsql-hackers@arkaria.postgresql.org; Sun, 13 Feb 2022 04:12:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ6Fu-0001nh-EY for pgsql-hackers@lists.postgresql.org; Sun, 13 Feb 2022 04:12:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJ6Fr-0002Zg-Vj for pgsql-hackers@lists.postgresql.org; Sun, 13 Feb 2022 04:12:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21D4CoOe2523850; Sat, 12 Feb 2022 23:12:50 -0500 From: Tom Lane To: Michael Paquier cc: Robert Haas , Andres Freund , PostgreSQL Hackers Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression. In-reply-to: References: <20220212220913.wnhgd7ak32srcmzo@alap3.anarazel.de> <2460218.1644704163@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Sun, 13 Feb 2022 12:28:31 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2523848.1644725570.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 12 Feb 2022 23:12:50 -0500 Message-ID: <2523849.1644725570@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote: >> I think adding an explicit PGAC_PATH_PROGS would be worth the cycles. > Well, this somebody is I, and the buildfarm did not blow up on any of > that so that looked rather fine. Eh? copperhead for one is failing for exactly this reason: Bailout called. Further testing stopped: failed to execute command "lz4 = -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_ch= eck/t_008_untar_primary_data/backup/server-backup/base.tar.lz4": No such f= ile or directory > Adding a few cycles for this check > is fine by me. What do you think of the attached? Looks OK as far as it goes ... but do we need anything on the MSVC side? Also, I can't help wondering why we have both GZIP_PROGRAM and GZIP variables. I suppose that's a separate issue though. regards, tom lane