Message-ID: <254b2fa2-2f6b-a30a-20ee-21f8a2c12a50@xs4all.nl>
Date: Thu, 4 Apr 2024 14:30:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: pgsql: Add basic JSON_TABLE() functionality
Content-Language: en-US
To: Amit Langote <amitlan@postgresql.org>,
 pgsql-committers@lists.postgresql.org
References: <E1rsL9y-000S60-Pn@gemulon.postgresql.org>
From: Erik Rijkers <er@xs4all.nl>
In-Reply-To: <E1rsL9y-000S60-Pn@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/254b2fa2-2f6b-a30a-20ee-21f8a2c12a50%40xs4all.nl>
Precedence: bulk

Op 4/4/24 om 13:21 schreef Amit Langote:
> Add basic JSON_TABLE() functionality
> 

Great that it's now committed. Congrats!


There is one 'uninitialized' muttering during compile (gcc 13.2.0):

In function ‘transformJsonFuncExpr’,
     inlined from ‘transformExprRecurse’ at parse_expr.c:373:13:
parse_expr.c:4317:34: warning: ‘default_format’ may be used 
uninitialized [-Wmaybe-uninitialized]
  4317 |         jsexpr->formatted_expr = transformJsonValueExpr(pstate, 
func_name,
       | 
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  4318 | 
                                         func->context_item,
       | 
                                         ~~~~~~~~~~~~~~~~~~~
  4319 | 
                                         default_format,
       | 
                                         ~~~~~~~~~~~~~~~
  4320 | 
                                         JSONBOID,
       | 
                                         ~~~~~~~~~
  4321 | 
                                         false);
       | 
                                         ~~~~~~
parse_expr.c: In function ‘transformExprRecurse’:
parse_expr.c:4257:24: note: ‘default_format’ was declared here
  4257 |         JsonFormatType default_format;
       |                        ^~~~~~~~~~~~~~


Thanks!

Erik