Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL3W3-0001dG-F1 for pgsql-committers@arkaria.postgresql.org; Thu, 26 Jan 2023 14:46:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pL3W2-0005Om-9w for pgsql-committers@arkaria.postgresql.org; Thu, 26 Jan 2023 14:46:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL3W2-0005OT-3F for pgsql-committers@lists.postgresql.org; Thu, 26 Jan 2023 14:46:14 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pL3Vz-0001Yk-K2 for pgsql-committers@lists.postgresql.org; Thu, 26 Jan 2023 14:46:13 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id CCAA920002; Thu, 26 Jan 2023 14:46:08 +0000 (UTC) Message-ID: <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> Date: Thu, 26 Jan 2023 09:46:07 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. Content-Language: en-US To: Robert Haas , Alvaro Herrera Cc: pgsql-committers@lists.postgresql.org References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-01-26 Th 08:00, Robert Haas wrote: > On Thu, Jan 26, 2023 at 6:58 AM Alvaro Herrera wrote: >> On 2023-Jan-24, Robert Haas wrote: >> >>> Adjust interaction of CREATEROLE with role properties. >> This commit broke the ability to run 'make installcheck' repeatedly, >> because it fails to drop role regress_role_limited_admin. > Argh, sorry. I keep making that mistake. Would it be worth adding a check right at the end of the schedule that makes sure there are no such roles left? cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com