Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyZFo-0003D4-1S for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 14:00:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oyZFm-0006UO-Tw for pgsql-committers@arkaria.postgresql.org; Fri, 25 Nov 2022 14:00:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyZFm-0006QG-MF for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 14:00:30 +0000 Received: from relay10.mail.gandi.net ([2001:4b98:dc4:8::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyZFi-00013u-K0 for pgsql-committers@lists.postgresql.org; Fri, 25 Nov 2022 14:00:30 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 9AABF240008; Fri, 25 Nov 2022 14:00:22 +0000 (UTC) Message-ID: <25eb9e88-2025-458c-2330-7fd5a56cbfcd@dunslane.net> Date: Fri, 25 Nov 2022 09:00:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Expand AclMode to 64 bits Content-Language: en-US To: Amit Langote Cc: Michael Paquier , pgsql-committers@lists.postgresql.org References: <7550ef36-4ec2-7b03-0671-0a88aab61ce7@dunslane.net> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-11-25 Fr 01:52, Amit Langote wrote: > Hi Andrew, > > On Thu, Nov 24, 2022 at 10:18 AM Andrew Dunstan wrote: >> On 2022-11-23 We 19:40, Michael Paquier wrote: >>> Hi Andrew, >>> >>> On Wed, Nov 23, 2022 at 07:44:04PM +0000, Andrew Dunstan wrote: >>>> Expand AclMode to 64 bits >>>> >>>> We're running out of bits for new permissions. This change doubles the >>>> number of permissions we can accomodate from 16 to 32, so the >>>> forthcoming new ones for vacuum/analyze don't exhaust the pool. >>>> >>>> Nathan Bossart >>>> >>>> Reviewed by: Bharath Rupireddy, Kyotaro Horiguchi, Stephen Frost, Robert >>>> Haas, Mark Dilger, Tom Lane, Corey Huinker, David G. Johnston, Michael >>>> Paquier. >>> crake is complaining for the upgrades from v12: >>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-11-23%2023%3A32%3A04 >>> >>> It seems that there are some tables dependent on aclitem, bumping on >>> your incompatible change. >> Yeah, testing a fix for it, thanks. > Not sure if it is related to the above, but I noticed a problem when > rebasing my patch that moves requiredPerms out of RangeTblEntry. I > think the commit may have missed doing the following (diff attached): pushed, thanks. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com