Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rac3I-00Ab7e-0D
	for pgsql-committers@arkaria.postgresql.org; Thu, 15 Feb 2024 13:45:24 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rac3F-00DWjr-T7
	for pgsql-committers@arkaria.postgresql.org; Thu, 15 Feb 2024 13:45:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1rac3F-00DWji-M1
	for pgsql-committers@lists.postgresql.org; Thu, 15 Feb 2024 13:45:21 +0000
Received: from wfout6-smtp.messagingengine.com ([64.147.123.149])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1rac3D-007KvW-1Y
	for pgsql-committers@lists.postgresql.org; Thu, 15 Feb 2024 13:45:21 +0000
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
	by mailfout.west.internal (Postfix) with ESMTP id BF4A31C000A1;
	Thu, 15 Feb 2024 08:45:14 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
  by compute2.internal (MEProxy); Thu, 15 Feb 2024 08:45:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org;
	 h=cc:content-transfer-encoding:content-type:content-type:date
	:date:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:subject:subject:to:to; s=fm3; t=1708004714;
	 x=1708091114; bh=jQ0xdusMO2ymFvr8oDARtXEe0bwqHwogYUGUFMljNcs=; b=
	SxP/Sf/oB8X9hUXqj8/7hCSvogT/1FU/pdUobud9+X2RuLpi8ziVnk/NC8UajvRv
	YAbhVJs/thYm2gqS01YZPYHKWaCNSJAmHhV0/GGaM5PUPVaAZ3qZw6IvD7DlTqL0
	lfM7H5PD8R7EFypsmCOw8i6tdUWaTLyKpQ7+k1UcJ9jUJO0LKvBETHBdZwQ53/Zb
	1HYkIBLdfvIUTNy5hck6QdEhnCd5Pym+ttFd6Odqxp10S5oaUnS9YsUiedzl5+jH
	CyZbxkYJRmYnWiyXRHP0svwph1BDPxM/Ttn7WjC79cP0ZEV3ZEE1h9SNuSGmPD6L
	YB9+0wiLEH06qdTl5xgW+Q==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-transfer-encoding:content-type
	:content-type:date:date:feedback-id:feedback-id:from:from
	:in-reply-to:in-reply-to:message-id:mime-version:references
	:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708004714; x=
	1708091114; bh=jQ0xdusMO2ymFvr8oDARtXEe0bwqHwogYUGUFMljNcs=; b=k
	ThiinVqbXIqfElDvmiul+2aO0akt6KN2XIQtgTvQ98pPYJSg4NqojyIS496kmCS3
	qibI42L/NqxQgvqTNFENGJgoLVeLRk+c1FRsGUDsaFG9WLvfK1ayXMPlD5F7tEvT
	VD+JudTM1yO2KwISWdklB12S93rihkCy9IytFEKd47N6ZdBwx8/VEYnO1YcXw/vT
	moenq9viXSAHlUl6xefup27mLmhD2yGFy/kBmhWfxbrnc3NfxAgq54HDza3jjwM2
	0CKCglWL1e1+gN5V//Yg4vArDILKbuPID/l2fwG7+5o5s8XcYGWKhSLwsNTz1cGa
	q/DEbWlh6bgHQhI1RMKBA==
X-ME-Sender: <xms:aRXOZSwvYpGkJUuLSlhFfhhwt8IfPazmzHXJKU8a-7sLFAbMYEgf3g>
    <xme:aRXOZeS5tQkMNhX7kPpsq9aKnI1M8t18Jpg6Ic2HDBC84mME5wxiVR9xrhpm5Dnof
    PBXyHGpr3e5Dfewxg>
X-ME-Received: 
 <xmr:aRXOZUVW83TCjymml9JPBQ1t4Fogavk0IEi7Etg_nMJHn7rEyVpV88tVzEjW_SA9mLU6xXcJu7NRbUsD1SWksGjoo-cTwrfGrA>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvledrvddtgdehiecutefuodetggdotefrodftvf
    curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
    uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
    fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghr
    ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne
    cuggftrfgrthhtvghrnhepheeivdfhuefhueeggfefheegjedtveeuhfethfeufedvudfg
    tdeuhefgfeduhfffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
    hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg
X-ME-Proxy: <xmx:aRXOZYglnQ2jNhpmfRe7cVdnVd7taRVz9-FJbQwyWoj4OT8yTPAyJA>
    <xmx:aRXOZUDvRMH-xgfq1JoEzkmgy8C8dBzhLULwPFXrK4tt4WzM9G9zpw>
    <xmx:aRXOZZL6M8niaj3OSyVY-pLEO6K8bbsxC_e6B9RAFv1QSr-2Nt6oDw>
    <xmx:ahXOZXOkhsta1Q8wdEbS2eXA4msT8TYhpMWDAq-wxzZu92IFg6FyY-AZZT4>
Feedback-ID: ie0a040ee:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 15 Feb 2024 08:45:13 -0500 (EST)
Message-ID: <25f7f4bf-9e75-4453-b666-7818000cefe6@eisentraut.org>
Date: Thu, 15 Feb 2024 14:45:11 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Allow upgrades to preserve the full subscription's state.
Content-Language: en-US
To: Amit Kapila <akapila@postgresql.org>,
 pgsql-committers@lists.postgresql.org
References: <E1rKV7t-00D3qt-Kc@gemulon.postgresql.org>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <E1rKV7t-00D3qt-Kc@gemulon.postgresql.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/25f7f4bf-9e75-4453-b666-7818000cefe6%40eisentraut.org>
Precedence: bulk

On 02.01.24 04:07, Amit Kapila wrote:
> Allow upgrades to preserve the full subscription's state.

The added test src/bin/pg_upgrade/t/004_subscription.pl does not pass when

export PG_TEST_PG_UPGRADE_MODE=--link

is set.

Could you check whether that could be fixed, or otherwise if the test 
needs to be skipped in that case?