Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYkTJ-0002dq-9V for pgsql-committers@arkaria.postgresql.org; Fri, 29 Jun 2018 03:53:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fYkTG-0005FN-Vu for pgsql-committers@arkaria.postgresql.org; Fri, 29 Jun 2018 03:53:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYkTG-0005FD-Nq for pgsql-committers@lists.postgresql.org; Fri, 29 Jun 2018 03:53:18 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fYkTE-00089T-5d for pgsql-committers@lists.postgresql.org; Fri, 29 Jun 2018 03:53:17 +0000 Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w5T3rAgC023181; Thu, 28 Jun 2018 23:53:10 -0400 From: Tom Lane To: Alvaro Herrera cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding In-reply-to: References: Comments: In-reply-to Alvaro Herrera message dated "Tue, 26 Jun 2018 20:50:03 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <26019.1530244389.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 28 Jun 2018 23:53:10 -0400 Message-ID: <26020.1530244390@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > Fix "base" snapshot handling in logical decoding According to buildfarm member friarbird, and as confirmed here, the contrib/test_decoding/specs/oldest_xmin.spec test added by this commit fails under CLOBBER_CACHE_ALWAYS. friarbird's error output doesn't seem to be getting captured by the buildfarm script, but what I see is *************** *** 16,21 **** --- 16,22 ---- = step s1_commit: COMMIT; step s0_vacuum: VACUUM FULL; + ERROR: canceling statement due to user request step s0_get_changes: SELECT data FROM pg_logical_slot_get_changes('isola= tion_s lot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1'); data = = which looks like it might just be a timeout problem. regards, tom lane