Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJPUD-0003vv-7Y for pgsql-committers@arkaria.postgresql.org; Wed, 12 Jul 2023 02:21:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qJPUA-0007DU-W8 for pgsql-committers@arkaria.postgresql.org; Wed, 12 Jul 2023 02:21:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJPUA-00077x-OQ for pgsql-committers@lists.postgresql.org; Wed, 12 Jul 2023 02:21:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qJPU6-003Mz2-5L for pgsql-committers@lists.postgresql.org; Wed, 12 Jul 2023 02:21:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 36C2LcSm2602084; Tue, 11 Jul 2023 22:21:38 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Integrate pg_bsd_indent into our build/test infrastructure. In-reply-to: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de> References: <20230711233307.hu4wetabjm5f7ver@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Tue, 11 Jul 2023 16:33:07 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2602082.1689128497.1@sss.pgh.pa.us> Date: Tue, 11 Jul 2023 22:21:38 -0400 Message-ID: <2602083.1689128498@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > And subsequently noticed that CI currently doesn't collect the tests.diff > file, so I don't know why that failed. CI currently collects all *.diffs > files, I don't really want it to also collect all .diff files, since most of > the time that would be redundant with the .diffs file. > Would you mind if I rename the output file to test.diffs? That seems to make > more sense than explicitly capturing this file... Sure, I did not realize we had a standard for that. regards, tom lane