Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M333374=pgsql-hackers-arkari@postgresql.org>)
	id 1di0gS-00010u-C5
	for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Aug 2017 15:56:40 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M333374=pgsql-hackers-arkari@postgresql.org>)
	id 1di0gR-0008Jq-Ro
	for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Aug 2017 15:56:39 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1di0gR-0008Jg-43
	for pgsql-hackers@postgresql.org; Wed, 16 Aug 2017 15:56:39 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1di0gO-0004VZ-43
	for pgsql-hackers@postgresql.org; Wed, 16 Aug 2017 15:56:37 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v7GFuYq1026169;
	Wed, 16 Aug 2017 11:56:34 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple
 expressions.
In-reply-to: 
 <CA+Tgmoan1cPF+rSPhX8NQ2p1pNPv+1NiqrPi-yA9ft6tyv+78A@mail.gmail.com>
References: <E1dhehy-00034e-8N@gemulon.postgresql.org>
 <23425.1502822098@sss.pgh.pa.us>
 <CA+TgmoaRuLrYSonO5y4-Dhiaw13yTukKWyJuRuCy2XHEAQ5O8A@mail.gmail.com>
 <31094.1502827694@sss.pgh.pa.us> <29231.1502831727@sss.pgh.pa.us>
 <CA+Tgmoa+h--4STWwP-+XkrSwcU8wWtNCV7ODcQZgyy=Xi+Np6g@mail.gmail.com>
 <7013.1502836842@sss.pgh.pa.us>
 <CA+TgmoYB4EfN4FkpWf3UFRgMgrA2Go7FgFmu-p7Yzh+WDx9E5A@mail.gmail.com>
 <23848.1502895834@sss.pgh.pa.us>
 <CA+Tgmoan1cPF+rSPhX8NQ2p1pNPv+1NiqrPi-yA9ft6tyv+78A@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Wed, 16 Aug 2017 11:22:29 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <26167.1502898994.1@sss.pgh.pa.us>
Date: Wed, 16 Aug 2017 11:56:34 -0400
Message-ID: <26168.1502898994@sss.pgh.pa.us>
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 16, 2017 at 11:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Well, it has subplans, so formally I think it's restricted not unsafe
>> --- but the parallel_safe marking on constructed paths/plans is only
>> safe/not-safe, not a three-way.

> True, but when parallel_safe it not set, that means it's not
> parallel-safe, so either parallel-restricted or parallel-unsafe.  But
> if parallelModeOK is true, then it had better be parallel-restricted,
> not parallel-unsafe.

Ah, I see.

> So I still don't see what's wrong here, other than that the comment is
> evidently not half clear enough.

I can get on board with that statement.  Can you draft a better wording?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers