Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rQrPq-003xPe-Vy
	for pgsql-committers@arkaria.postgresql.org; Fri, 19 Jan 2024 16:08:23 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rQrPp-00AD05-G6
	for pgsql-committers@arkaria.postgresql.org; Fri, 19 Jan 2024 16:08:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rQrPp-00ACzx-91
	for pgsql-committers@lists.postgresql.org; Fri, 19 Jan 2024 16:08:21 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rQrPl-002etw-J1; Fri, 19 Jan 2024 16:08:20 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 40JG8FZC2621750;
	Fri, 19 Jan 2024 11:08:15 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <akorotkov@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()
In-reply-to: <E1rQqeS-002A0s-Qm@gemulon.postgresql.org>
References: <E1rQqeS-002A0s-Qm@gemulon.postgresql.org>
Comments: In-reply-to Alexander Korotkov <akorotkov@postgresql.org>
	message dated "Fri, 19 Jan 2024 15:19:24 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2621748.1705680495.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 19 Jan 2024 11:08:15 -0500
Message-ID: <2621749.1705680495@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/2621749.1705680495%40sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <akorotkov@postgresql.org> writes:
> Reorder actions in ProcArrayApplyRecoveryInfo()

I'm seeing this warning since this commit:

procarray.c: In function 'ProcArrayApplyRecoveryInfo':
procarray.c:1172:17: warning: declaration of 'xid' shadows a previous loca=
l [-Wshadow=3Dcompatible-local]
   TransactionId xid =3D running->xids[i];
                 ^~~
procarray.c:1056:16: note: shadowed declaration is here
  TransactionId xid;
                ^~~

			regards, tom lane